Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tibuild): fix devbuild tekton cloudevent extension key #197

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Nov 5, 2024

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from purelind November 5, 2024 12:53
Copy link

ti-chi-bot bot commented Nov 5, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the title and description of the pull request, it seems that the changes are related to fixing an issue with a Tekton CloudEvent extension key in the tibuild/pkg/rest/service/cloud_event_client.go file.

The key change in this pull request is in the line event.SetExtension("param-builder-image", dev.Spec.BuilderImg) where the key name is changed to paramBuilderImage.

There doesn't seem to be any potential problems with this change as it is a simple renaming of the key name. However, it is always recommended to test the changes before merging the pull request.

One suggestion for fixing would be to add a comment explaining the reason for the change, so that other developers can understand the context of the change in the future.

@ti-chi-bot ti-chi-bot bot added the size/XS label Nov 5, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Nov 5, 2024

/approve

Copy link

ti-chi-bot bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit 31622fb into main Nov 5, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/fix-devbuild-tekton-ce-extensions branch November 5, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant