feat(tiup-worker): add distribute publishing lock #208
Conversation
Implement the lock with redlock on redis Signed-off-by: wuhuizuo <[email protected]>
The key change is that the PR implements a distributed lock with redlock on Redis, which prevents multiple instances of the same program from executing the same code simultaneously. This will be useful in the case where multiple instances of the same program attempt to publish a package at the same time. There are no apparent problems with the changes made in this PR. However, one suggestion to improve the code quality is to extract the mutex-related variables into constants or variables at the package level, and to add unit tests to verify the correctness of the locking mechanism. Another suggestion is to add more descriptive error messages for debugging purposes. This will make it easier to diagnose any issues that may arise in the future. Overall, the changes made in this PR seem to be well thought out and implemented. The author has done a good job of adding a distributed lock to prevent race conditions, and the changes are likely to be beneficial to the codebase. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-15-gf0b4200 (#1361) Deploy with feature: PingCAP-QE/ee-apps#208 Signed-off-by: wuhuizuo <[email protected]> Signed-off-by: wuhuizuo <[email protected]>
Implement the lock with redlock on redis
Signed-off-by: wuhuizuo [email protected]