Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(apps/prod/cloudevents-server): switch db backend from sqlite to tidb #742

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind October 31, 2023 10:46
@ti-chi-bot ti-chi-bot bot added the area/apps label Oct 31, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
This pull request is switching the database backend from SQLite to TiDB for the cloudevents-server application. The changes include deleting the data-pvc.yaml and config-configmap.yaml files that are used to create a Persistent Volume Claim and ConfigMap for SQLite. Also, the release.yaml file is updated to use the new TiDB image.

There may be some potential problems with this pull request. First, it is not clear if the new TiDB backend has been fully tested. Second, it is not clear if there are any compatibility issues between the old SQLite database and the new TiDB database. Third, the pull request does not provide any information on how to migrate data from the old SQLite database to the new TiDB database.

To fix these issues, it is recommended to add more information to the pull request, such as test results and migration instructions. The pull request could also include a rollback plan in case the new TiDB database causes any issues.

@ti-chi-bot ti-chi-bot bot added env/prod will deploy on the main product cluster size/M labels Oct 31, 2023
@wuhuizuo
Copy link
Collaborator Author

There may be some potential problems with this pull request. First, it is not clear if the new TiDB backend has been fully tested. Second, it is not clear if there are any compatibility issues between the old SQLite database and the new TiDB database. Third, the pull request does not provide any information on how to migrate data from the old SQLite database to the new TiDB database.

It's tested offline.

@wuhuizuo
Copy link
Collaborator Author

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 31, 2023
@ti-chi-bot ti-chi-bot bot merged commit 3865d77 into main Oct 31, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/update-cloudevents-server branch October 31, 2023 11:08
wuhuizuo added a commit that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant