WPP15 - User Page #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started user profile page base
Only using this to observe User Page functionality. Will implement using actual userID's later
More description, but my styling is not the greatest at the moment
Uses userID when guiding to the page route
Placed in the header and created the change password component
The modal actually works this time.
This reverts commit d867a3f.
This will come in handy for future use
Ignore the change password button being purple... that's not important...
User page tests are next
Still need to complete a couple render tests
Not refactoring anything else unless needed. Don't want it to crash
prewe5294
requested changes
Apr 27, 2023
| <img className="userPage_ProfilePicture" src={userIcon} data-testid="profilePic" height="75" /> | ||
| </div> | ||
| <div> | ||
| <p className="userPage_Username" data-testid="usename"> Username goes here! </p> |
There was a problem hiding this comment.
wouldn't it be better to actually display the username, as is mentioned in this user story
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Pull Requesters/Reviewers:
All of the following should be true before making a pull request and should be inspected by reviewers:
User Story
Unit Testing
Documentation/Style
For Reviewers:
The following should be additionally checked by reviewers:
Description
Insert here the description of what your PR does.