-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: core lib improvments & multiple bug fixes #331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de5aca8
to
4872059
Compare
Benchmark for 7898a07Click to view benchmark
|
4872059
to
7ca9aa0
Compare
Benchmark for 1873461Click to view benchmark
|
1. add monad functions to `Result` type 2. update io read function to use `Result` monad 3. fix some of the generated visit function not found during link time when optimization level is greater than 0. 4. update test expects
Benchmark for edb083aClick to view benchmark
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 85.80% 86.38% +0.58%
==========================================
Files 100 103 +3
Lines 21214 22126 +912
==========================================
+ Hits 18202 19114 +912
Misses 3012 3012
|
Benchmark for 98c6698Click to view benchmark
|
Benchmark for 88d1804Click to view benchmark
|
module之前包含的所有submodule都是直接存的值,每次clone整个依赖树跟着clone,文件一多直接卡爆 现在我把submodule搞了个rc,直接300ms->20ms,遥遥领先!
Benchmark for c3dfb7cClick to view benchmark
|
Benchmark for d096712Click to view benchmark
|
Benchmark for ce43835Click to view benchmark
|
1. generic trait implicit cast use placeholder function to build vtable 2. array visit function's counter noy initialized to zero
Benchmark for 1c9988cClick to view benchmark
|
95e086e
to
5c9d65f
Compare
Benchmark for 25a8ce7Click to view benchmark
|
Previous implementation set the generic type to it's trait bound type during analysis, witch causing issue during code gen process, also generation useless code even when a generic function is not use. This commit will construct a new temporary type which auto implements the corrsponding trait bounds, and avoid code gen completely when generic function is not instanciated.
5c9d65f
to
a4a7753
Compare
Benchmark for ccbb9d0Click to view benchmark
|
Benchmark for da21b6dClick to view benchmark
|
this may cause segment fault occasionally
Benchmark for 3dbd9c0Click to view benchmark
|
Benchmark for 209f776Click to view benchmark
|
Benchmark for b25da3dClick to view benchmark
|
Benchmark for 1fe2627Click to view benchmark
|
Benchmark for aa161c0Click to view benchmark
|
Benchmark for 6638e8fClick to view benchmark
|
Benchmark for 886ebfeClick to view benchmark
|
RINNE-TAN
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large pr. As porting libc and improve std lib are long term tasks, I decided to
merge this pr before its done as there's already too much bug fixes and code changes.
modification list
close #340
close #321
half done #316