Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug when containerUrl ends with trailing slash #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robfuncken
Copy link

When the provided containerUrl ends with a trailing slash, the generated url for the tracking js doesn't work.

This fixes that problem by sanitising the input.

Copy link
Contributor

@lysy-vlc lysy-vlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auto200 What do You think about moving it to the base tracking package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants