APPLE: Fix Missing cstdef #3535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An upstream change to Clang ( https://discourse.llvm.org/c/announce/46 ) will require that size_t be explicitly brought in from a header, rather than implicitly used, as it allows delineation between different declarations of size_t. This change brings them in from cstddef and prefixes them with the std namespace
|
Filed as internal issue #USD-10686 (This is an automated message. See here for more information.) |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
An upstream change to Clang will require that size_t be explicitly brought in from a header, rather than implicitly used, as it allows delineation between different declarations of size_t.
The compiler versions are free to move around and/or remove unnecessary implicit includes internally to improve build times regularly and breaks folks accidentally relying on transitive includes quite often. libc++ 20.0.0 removed some transitive includes which causes breakages in code that was accidentally relying on those, violating the "include-what-you-use" principle
This change brings them in from cstddef and prefixes them with the std namespace
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)