APPLE: Update LibPNG to 1.6.47 #3552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An upcoming compiler change for Clang is causing issues with the version of LibPNG as used by build_usd.py This change causes some of the LibPNG ifdefs to fail, causing it to try and bring in fp.h instead of math.h (https://github.com/pnggroup/libpng/blob/v1.6.38/pngpriv.h#L524) This was fixed in 1.6.41 with this commit (pnggroup/libpng@893b811) Since we have to update the libPng version anyway, I just opted to use the most recent version.
|
Filed as internal issue #USD-10714 (This is an automated message. See here for more information.) |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
An upcoming compiler change for Clang is causing issues with the version of LibPNG as used by build_usd.py
This change causes some of the LibPNG ifdefs to fail, causing it to try and bring in fp.h instead of math.h (https://github.com/pnggroup/libpng/blob/v1.6.38/pngpriv.h#L524)
This was fixed in 1.6.41 with this commit (pnggroup/libpng@893b811)
Since we have to update the libPng version anyway, I just opted to use the most recent version.
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)