Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module_manager): PPT-1636 refactor to use empty settings when merge settin… #275

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

naqvis
Copy link
Contributor

@naqvis naqvis commented Nov 14, 2024

No description provided.

@naqvis naqvis requested a review from stakach November 14, 2024 08:14
@github-actions github-actions bot added the type: bug something isn't working label Nov 14, 2024
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Nov 14, 2024
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Nov 14, 2024
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stakach stakach merged commit 2ca94ec into master Nov 20, 2024
11 checks passed
@stakach stakach deleted the PPT-1636 branch November 20, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants