Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PPT-1701 added extra endpoints for recompile and reload #276

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

naqvis
Copy link
Contributor

@naqvis naqvis commented Nov 22, 2024

No description provided.

@naqvis naqvis requested a review from stakach November 22, 2024 01:58
@github-actions github-actions bot added the type: enhancement new feature or request label Nov 22, 2024
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Nov 22, 2024
shard.yml Outdated
@@ -75,6 +75,8 @@ dependencies:
github: spider-gazelle/connect-proxy
version: ~> 2.0

git-repository:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? I don't think core uses it anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we are using this shard in driver_manager.cr. This shard is used to perform HTTP client functionality

@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Nov 25, 2024
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Nov 26, 2024
@stakach stakach self-requested a review November 26, 2024 01:11
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naqvis naqvis merged commit f191764 into master Nov 26, 2024
11 checks passed
@naqvis naqvis deleted the PPT-1701 branch November 26, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants