Skip to content

fix(Dockerfile): owner user must exist on the filesystem #163

fix(Dockerfile): owner user must exist on the filesystem

fix(Dockerfile): owner user must exist on the filesystem #163

GitHub Actions / Ameba failed Nov 14, 2024 in 1s

Crystal Ameba Results

Total files checked: 54
Issues found: 40

Ameba Version: 1.6.3
Crystal Version: 1.10.0

Annotations

Check notice on line 18 in src/edge-app.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> parser.on("-u", "--uri", "Set URI for PlaceOS instance") { |u| uri = URI.parse(u) }
                                                              ^

Check notice on line 20 in src/edge-app.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> parser.on("-s", "--secret", "Set application secret") { |s| secret = s }
                                                           ^

Check notice on line 17 in src/core-app.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> parser.on("-b HOST", "--bind=HOST", "Specifies the server host") { |h| host = h }
                                                                      ^

Check notice on line 18 in src/core-app.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> parser.on("-p PORT", "--port=PORT", "Specifies the server port") { |p| port = p.to_i }
                                                                      ^

Check notice on line 20 in src/core-app.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> parser.on("-w COUNT", "--workers=COUNT", "Specifies the number of processes to handle requests") do |w|
                                                                                                       ^

Check notice on line 25 in src/placeos-core/healthcheck.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> ::DB.connect(pg_healthcheck_url) do |db|
                                       ^

Check notice on line 160 in src/placeos-core/process_manager/edge.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> private getter debug_callbacks = Hash(String, Array(DebugCallback)).new { |h, k| h[k] = [] of DebugCallback }
                                                                             ^

Check warning on line 93 in src/placeos-edge/protocol.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Documentation/DocumentationAdmonition

Found a TODO admonition in a comment
Raw output
> # TODO: Refactor Message for better type safety
  ^

Check warning on line 21 in src/placeos-edge/protocol.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Lint/UselessAssign

Useless assignment to variable `sequence_id`
Raw output
> field sequence_id : UInt64
        ^

Check warning on line 23 in src/placeos-edge/protocol.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Lint/UselessAssign

Useless assignment to variable `status`
Raw output
> field status : Status = Status::Success
        ^

Check warning on line 24 in src/placeos-edge/protocol.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Lint/UselessAssign

Useless assignment to variable `length`
Raw output
> field length : Int32, value: ->{ key.bytesize }
        ^

Check warning on line 25 in src/placeos-edge/protocol.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Lint/UselessAssign

Useless assignment to variable `key`
Raw output
> field key : String, length: ->{ length }
        ^

Check notice on line 150 in src/placeos-edge/protocol.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> {% for response in Type.constants.map { |t| ({t.underscore, t}) } %}
                                           ^

Check notice on line 386 in src/placeos-edge/protocol.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods

Consider using 'getter?' for 'success'
Raw output
> getter success : Bool
         ^

Check notice on line 106 in src/placeos-core/driver_manager.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> File.open(filename, "wb+") do |f|
                                 ^

Check notice on line 19 in spec/placeos-edge/client_spec.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> server_ws.on_message do |m|
                           ^

Check warning on line 28 in src/placeos-core/process_check.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Documentation/DocumentationAdmonition

Found a TODO admonition in a comment
Raw output
> # TODO:
  ^

Check notice on line 93 in src/placeos-core/process_check.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> fresh_module_ids = module_managers.compact_map do |module_id, pm|
                                                                ^

Check warning on line 286 in src/placeos-core/module_manager.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Documentation/DocumentationAdmonition

Found a TODO admonition in a comment
Raw output
> # TODO: Cache `Module` to `Edge` relation in `ModuleManager`
  ^

Check notice on line 202 in spec/helper.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods

Consider using 'getter?' for 'unregister'
Raw output
> getter unregister : Bool = true
         ^

Check notice on line 66 in spec/api/command_spec.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> ws_client.on_message do |m|
                           ^

Check notice on line 55 in spec/processes/edge_spec.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> with_edge do |ctx, _client, pm|
                              ^

Check notice on line 82 in spec/processes/edge_spec.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> with_edge do |ctx, client, pm|
                             ^

Check notice on line 90 in spec/processes/edge_spec.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> with_edge do |_ctx, client, pm|
                              ^

Check notice on line 99 in spec/processes/edge_spec.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/BlockParameterName

Disallowed block parameter name found
Raw output
> with_edge do |ctx, client, pm|
                             ^