Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update oauth_applications.cr to use assign_attributes_from_json #362

Closed
wants to merge 1 commit into from
Closed

fix: Update oauth_applications.cr to use assign_attributes_from_json #362

wants to merge 1 commit into from

Conversation

grkek
Copy link

@grkek grkek commented Oct 10, 2023

No description provided.

@grkek
Update oauth_applications.cr
44346e9 
Switch from assign_attributes to assign_attributes_from_json
@grkek grkek requested review from stakach and naqvis October 10, 2023 05:23
@github-actions github-actions bot added the type: bug something isn't working label Oct 10, 2023
stakach
stakach requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to resolve at the active_model level. The assign_attributes method is used in every controller

@grkek
Copy link
Author

grkek commented Oct 10, 2023

We need to resolve at the active_model level. The assign_attributes method is used in every controller

The issue is the fact that when we cast a model from JSON it doesn't change the {{attribute}}_has_changed to true, when we use the assign_attributes_from_json it works as intended.

@stakach stakach closed this in 8768ba3 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stakach stakach stakach requested changes

@naqvis naqvis Awaiting requested review from naqvis

Assignees

@grkek grkek

Labels
type: bug something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grkek @stakach