Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(asset_types): PPT-1803 index endpoint when no matching entries found #398

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix(asset_types): PPT-1803 index endpoint when no matching entries found #398

merged 2 commits into from
Feb 4, 2025

Conversation

naqvis
Copy link
Contributor

@naqvis naqvis commented Jan 27, 2025

No description provided.

@naqvis naqvis requested a review from stakach January 27, 2025 09:43
@github-actions github-actions bot added the type: bug something isn't working label Jan 27, 2025
stakach
stakach requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should actually return an empty array - to match the behavior of other routes

@naqvis naqvis requested a review from stakach February 4, 2025 07:46
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Feb 4, 2025
stakach
stakach approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stakach stakach changed the title fix(asset_types): PPT-1803 index endpoint to return 404 when no matching entries found fix(asset_types): PPT-1803 index endpoint when no matching entries found Feb 4, 2025
@stakach stakach merged commit e45d652 into master Feb 4, 2025
7 of 10 checks passed
@stakach stakach deleted the PPT-1803 branch February 4, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stakach stakach stakach approved these changes

Assignees

@naqvis naqvis

Labels
type: bug something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naqvis @stakach