Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events): setup/breakdown events #299

Closed
wants to merge 7 commits into from
Closed

feat(events): setup/breakdown events #299

wants to merge 7 commits into from

Conversation

chillfox
Copy link
Contributor

@chillfox chillfox commented Sep 22, 2023 •
edited
Loading

TODO:

@chillfox chillfox self-assigned this Sep 22, 2023
@github-actions github-actions bot added the type: enhancement new feature or request label Sep 22, 2023
@chillfox
Merge branch 'master' into PPT-685-concierge-room-availability-result…
ae041fc 
…s-do-not-reflect-setup-breakdown-times-and-book-new-events-directly-over-them
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Sep 22, 2023
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Sep 22, 2023
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Sep 22, 2023
stakach
stakach requested changes Sep 22, 2023
View reviewed changes
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think as discussed we should update the delete signal to include the metadata and then perform the management of the setup and breakdown events in the driver

@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Oct 4, 2023
@chillfox chillfox closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stakach stakach stakach requested changes

Assignees

@chillfox chillfox

Labels
type: enhancement new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chillfox @stakach