Initialize camera image gain to a consistent ISO of 150 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a fix for a regression reported to me (privately, in DMs) by @fabienlombard on PlanktoScope OS v2024.0.0-beta.1, in which the default ISO setting displayed on the Node-RED dashboard was inconsistent with the actual initial image gain (of 1.0, which corresponds to an ISO of ~54 on the PlanktoScope hardware v2.1's camera and an ISO of ~43 on the PlanktoScope hardware v2.3+'s camera). This PR initializes the image gain value to match a consistent ISO setting of 150, which will become the default ISO setting for both the adafruithat Node-RED dashboard and the planktoscopehat Node-RED dashboard.
This fix was discussed and approved in the 2024-07-25 software meeting.