Fix incorrect use of img_rank field in EcoTaxa export metadata
#70
+17
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2024
|
This PR was approved for merging in the 2024-12-19 software meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem reported by @fabienlombard on the PlanktoScope Slack workspace, in which the segmenter's behavior to set the
img_rankmetadata field to the index of the image in the entire dataset was incorrect; that rank is instead supposed to be used to set a display priority among alternate images (e.g. brightfield vs fluorescence) corresponding to the same object. And EcoTaxa cannot handleimg_rankvalues above ~32700, so larger datasets exported by the segmenter could not be imported to EcoTaxa. Now we just setimg_rankto1for all object images, since we only export one image per object.