Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liftoff possibly creating CDS with '.' in phase column? #115

Closed
GallVp opened this issue Nov 29, 2024 · 1 comment
Closed

Liftoff possibly creating CDS with '.' in phase column? #115

GallVp opened this issue Nov 29, 2024 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@GallVp
Copy link
Member

GallVp commented Nov 29, 2024

Description of the bug

CDS features with '.' in the phase column (8) is not permissible. This might be causing the following error downstream in the pipeline. An issue on the liftoff repo mentions something similar. See: agshumate/Liftoff#67

Command executed:

tsebra.py
-g eriantha_h2.clean.gtf
-e hintsfile.gff

-c tsebra-config.cfg

-o eriantha_h2.gtf
-s eriantha_h2.tsv

cat <<-END_VERSIONS > versions.yml
"PLANTFOODRESEARCHOPEN_GENEPAL:GENEPAL:FASTA_LIFTOFF:GFF_TSEBRA_SPFILTERFEATUREFROMKILLLIST:TSEBRA":
tsebra: 1.1.2.5
END_VERSIONS

Command exit status:
1

Command output:
(empty)

Command error:

READING GENE PREDICTION: [eriantha_h2.clean.gtf]

READING EXTRINSIC EVIDENCE: [hintsfile.gff]

BUILD OVERLAP GRAPH

Traceback (most recent call last):
File "/usr/local/bin/tsebra.py", line 235, in
main()
File "/usr/local/bin/tsebra.py", line 97, in main
graph.build()
File "/usr/local/bin/overlap_graph.py", line 185, in build
if self.compare_tx_cds(tx1, tx2):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/bin/overlap_graph.py", line 207, in compare_tx_cds
coords += [c + [int(phase)] for phase, coord_phase in tx1.get_type_coords('CDS').items() for c in coord_phase]
^^^^^^^^^^
ValueError: invalid literal for int() with base 10: '.'

Command used and terminal output

nextflow run plant-food-research-open/genepal \
--outdir 's3://***' \
-r '0.5.0' \
-params-file params.json \
-c mmc.config \
-resume

Relevant files

No response

System information

plant-food-research-open/genepal 0.5.0

@GallVp GallVp added the bug Something isn't working label Nov 29, 2024
@GallVp GallVp added this to the 0.5.1 milestone Nov 29, 2024
@GallVp GallVp self-assigned this Nov 29, 2024
@GallVp GallVp linked a pull request Dec 2, 2024 that will close this issue
10 tasks
@GallVp
Copy link
Member Author

GallVp commented Dec 5, 2024

In the reported version plant-food-research-open/genepal 0.5.0, this is not possible as GFFREAD is run before and after LIFTOFF. GFFREAD automatically fixes the phase column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant