Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an issue where TSEBRA failed due to '.' in phase column from LIFTOFF #117

Closed
wants to merge 4 commits into from
Closed

Fixed an issue where TSEBRA failed due to '.' in phase column from LIFTOFF #117

wants to merge 4 commits into from

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Dec 2, 2024

PR checklist

  • Fixed an issue where TSEBRA failed due to '.' in phase column from LIFTOFF
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a4ae9f6

+| ✅ 104 tests passed       |+
#| ❔  19 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: assets/nf-core-genepal_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-genepal_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-genepal_logo_dark.png
  • nextflow_config - nextflow_config
  • files_unchanged - File does not exist: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File does not exist: assets/nf-core-genepal_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-genepal_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-genepal_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/genepal/genepal/.github/workflows/awstest.yml
  • included_configs - included_configs

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-02 08:55:17

@GallVp GallVp linked an issue Dec 2, 2024 that may be closed by this pull request
Liftoff possibly creating CDS with '.' in phase column? #115
Closed
@GallVp GallVp marked this pull request as draft December 2, 2024 20:39
@GallVp
Copy link
Member Author

GallVp commented Dec 4, 2024

A test case is needed before this can be merged.

@GallVp
Copy link
Member Author

GallVp commented Dec 5, 2024

Closing this as it does not solve anything. See #115

@GallVp GallVp closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Liftoff possibly creating CDS with '.' in phase column?
1 participant
@GallVp