load total number of donated trees dynamically #2056

norbertschuler · 2024-04-28T10:04:59Z

Fixes https://planetfoundation.slack.com/archives/C015AEAU75Z/p1714117221663939?thread_ts=1713974028.645419&cid=C015AEAU75Z

Changes in this pull request:

load the number of total donated trees dynamically

To-Do:

do we want to configure the URL for https://automate.plant-for-the-planet.org/webhook/ in the environment like we already did for the Salesforce deplyoment defined as WEBHOOK_URL?
do we really want to display this number dynamically?

coderabbitai · 2024-04-28T10:05:06Z

Walkthrough

The recent changes involve integrating environmental contributions data, specifically trees donated, into the LeaderBoard components across different files. This includes adding new types and updating component props to handle this new data, enhancing the feature's interactivity and informational depth.

Changes

File Path	Change Summary
`pages/sites/[slug]/[locale]/all.tsx`	Added `TreesDonated` import, state, and effect, removed `redirect`.
`src/features/common/types/leaderboard.d.ts`	Added `TreesDonated` type definition.
`src/tenants/planet/LeaderBoard/components/Stats.tsx`	Updated to include `TreesDonated` in props and logic.
`src/tenants/planet/LeaderBoard/index.tsx`	Added `treesDonated` to props and conditional rendering logic.

Poem

🐇✨
A hop through code, a leap through trees,
We count each leaf, with the greatest of ease.
From branch to branch, our data will flow,
In LeaderBoards, where green numbers grow.
🌳📈💚

CodeRabbit 🐰

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f411a39 and 27bb043.

Files ignored due to path filters (1)

app.json is excluded by !**/*.json

Files selected for processing (5)

next.config.js (1 hunks)
pages/sites/[slug]/[locale]/all.tsx (3 hunks)
src/features/common/types/leaderboard.d.ts (1 hunks)
src/tenants/planet/LeaderBoard/components/Stats.tsx (2 hunks)
src/tenants/planet/LeaderBoard/index.tsx (1 hunks)

Files skipped from review due to trivial changes (1)

next.config.js

Files skipped from review as they are similar to previous changes (4)

pages/sites/[slug]/[locale]/all.tsx
src/features/common/types/leaderboard.d.ts
src/tenants/planet/LeaderBoard/components/Stats.tsx
src/tenants/planet/LeaderBoard/index.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2024-04-28T10:05:07Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp	✅ Ready (Inspect)	Visit Preview		Apr 30, 2024 3:04pm
planet-webapp-multi-tenancy-setup	✅ Ready (Inspect)	Visit Preview		Apr 30, 2024 3:04pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp-temp	⬜️ Ignored (Inspect)			Apr 30, 2024 3:04pm

mohitb35

Codewise, LGTM.

I think the webhook url should be kept in the environment, we plan to do this while migrating the salesforce tenant to the multitenant project anyway.

Not sure if we want to hold off on release due to reasons of data consistency.

Note: Release of these changes would not reflect on www1.plant-for-the-planet.org in the current setup.

norbertschuler · 2024-04-29T09:50:57Z

Ok, I'll just keep this as a draft until releases will work normally again.

sagararyal · 2024-04-30T13:43:38Z

@mohitb35 What's the data inconsistency issue?

The numbers shared generally was from Q1. vs the query returns number for 1 week ago.

mohitb35 · 2024-04-30T13:52:44Z

There isn't any issue as such, but we do choose to hardcode certain figures at times, and I wondered if this was one of those cases.

mohitb35 · 2024-04-30T13:56:05Z

@norbertschuler We can release this now, since www1.plant-for-the-planet.org is now redirected to web.plant-for-the-planet.org, so changes will be visible.

norbertschuler · 2024-04-30T15:07:03Z

@norbertschuler We can release this now, since www1.plant-for-the-planet.org is now redirected to web.plant-for-the-planet.org, so changes will be visible.

Ok, I added using an env named WEBHOOK_URL which I also added to all deployments at Heroku and Vercel.

load total number of donated trees dynamically

2d80140

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup April 28, 2024 10:11 View deployment

norbertschuler requested a review from mohitb35 April 28, 2024 10:12

vercel bot deployed to Preview – planet-webapp April 28, 2024 10:19 View deployment

mohitb35 approved these changes Apr 29, 2024

View reviewed changes

norbertschuler marked this pull request as ready for review April 30, 2024 14:34

vercel bot deployed to Preview – planet-webapp April 30, 2024 14:39 View deployment

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup April 30, 2024 14:40 View deployment

use env for web hook url

27bb043

norbertschuler force-pushed the feature/dynamic_stats_number_of_donated_trees branch from 057e7b0 to 27bb043 Compare April 30, 2024 14:55

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup April 30, 2024 15:04 View deployment

vercel bot deployed to Preview – planet-webapp April 30, 2024 15:04 View deployment

norbertschuler merged commit 097b720 into develop Apr 30, 2024
8 checks passed

norbertschuler deleted the feature/dynamic_stats_number_of_donated_trees branch April 30, 2024 15:07

mariahosfeld mentioned this pull request May 7, 2024

Release small fixes May 2024 #2061

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

load total number of donated trees dynamically #2056

load total number of donated trees dynamically #2056

norbertschuler commented Apr 28, 2024 •

edited

Loading

coderabbitai bot commented Apr 28, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

vercel bot commented Apr 28, 2024 •

edited

Loading

mohitb35 left a comment •

edited

Loading

norbertschuler commented Apr 29, 2024

sagararyal commented Apr 30, 2024

mohitb35 commented Apr 30, 2024

mohitb35 commented Apr 30, 2024

norbertschuler commented Apr 30, 2024

load total number of donated trees dynamically #2056

load total number of donated trees dynamically #2056

Conversation

norbertschuler commented Apr 28, 2024 • edited Loading

coderabbitai bot commented Apr 28, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

vercel bot commented Apr 28, 2024 • edited Loading

mohitb35 left a comment • edited Loading

Choose a reason for hiding this comment

norbertschuler commented Apr 29, 2024

sagararyal commented Apr 30, 2024

mohitb35 commented Apr 30, 2024

mohitb35 commented Apr 30, 2024

norbertschuler commented Apr 30, 2024

norbertschuler commented Apr 28, 2024 •

edited

Loading

coderabbitai bot commented Apr 28, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

vercel bot commented Apr 28, 2024 •

edited

Loading

mohitb35 left a comment •

edited

Loading