Base PR: Projects Redesign

[mohitb35]

Final Cleanup

• Revert husky logic change before merging to develop
• Replace the /prd route with /, and archive the old projects pages
• Consolidate translations so that we are not referring to the 'ManageProjects' namespace, if possible.
• Review temp folder and move icons/assets that are being used in v2 out of /temp
• Add meta tags GetProjectsMeta and GetAllProjectsMeta

Later

• We need an additional way to close the filter list, e.g., an "x" or a click next to the list, as it now overlaps until we click the filter icon again, probably not intuitive for most users. @gangakhushlani , maybe you can help here as well
• On mobile: Without tabs to filter for Top Project v. All when in map view, at least to me the search and filter option gets a bit lost (depending on the map position). Improvement needed, @gangakhushlani , can you check this out? >> For now, just keeping box shadow
• mobile controls - with remote sensing
  • explore (to check layout, comment out before release)
• static image of site on map (backend?) - later
• Scroll issue on Safari iOS e.g. when plant location is selected and swipeable view is visible.
• Remove stories after usefulness is over.
• when I go to the map view, open a project card, and then click the back arrow from the project’s full view, it takes me to the list view instead of returning to the map view. It should take me back to the map view. Maintain page state when the user goes back (including filters/search)
• the zoom buttons should be properly located in the bottom corner with equal padding at the bottom as on the right?
• Marker navigation and popup display on mobile (for list screen)- to be discussed and refined
• Identify duplicate code esp. common helpers/utils.

Todo

• Fetch project list data
• Before release: Review font sizes across implementation and adamend if needed
• Back button logic from project details, in different scenarios (embed mode, visit from different site, visit from email, visit from same site) (in review)
• Prevent loader display when projects are already available in list (e.g. after coming back from a project) - ref Projects redesign/zoom into site #2209 (comment)
• Translation issue while switching languages
• Test out embed state and other query params
  • embed
  • back_icon
  • callback
  • project_details
  • project_list
  • enable_intro
• Test out impersonation mode

Done

1. Basic structure for redesigned pages

Open (may be addressed later)

• Updated footer design, use | as a divider (in review)
• Remove horizontal dividers in yellow box within project details
• Zoom to center of results on search/filter??
• Check zoom behavior for zooming into site, should stop before last "jump"
• Check and consolidate font sizes across pages, currently in some places the fonts are too small
• Include "Report" in the clickable area to download the project review (currently only the download symbol)
• Include localized separators for planting density
• Amend the placement of the zoom buttons on mapview (lower corner, right and bottom equal padding) (mobile and desktop)
• Expand clickable area in project pop-up (on map) so that most of it is included and will lead to project
• handle error when map tries to show satellite layer when site layer is not there (no sites scenario) e.g. /prd/mothersforest
• footer buttons should have a hover state
• At the single project level, the text is too small. Please have all the body text be the same size as the tree price text

Project Details Minor Open Points (carried forward)

• sample plant location/ plant location functionality (swipeable layout)
• Evaluate styles/classes defined for KeyInfo / AdditionalInfo. For example, we have no class defined called infoDetail but this is used in AdditionalInfo, and KeyInfo has code which results in nested singleRowInfoContainer classes. Refactor, and rename where needed. (In review)
• Consolidated UI check - list page
  • mobile
  • desktop
• Consolidated UI check - details page
  • mobile
  • desktop
• Code cleanup -
  • logic to update url params for site/ploc, set selected plant locations, selected sites, selected plant locations etc. exists in many places, make this easier to understand and manage
  • Check for references to old project code and separate where needed
  • import types explicitly (consistent-type-imports)
• I noticed that multiple calls are made to the plantLocations API in mobile devices (map mode) - This is getting called everytime map mode is exited
• Handle case of setting site id to 0 when project has no sites. example (mothersforest project unselecting a plant location; ploc param remains in the url)
• When I opened /prd/trees-for-peace-an-ayudh-europe-campaign, I saw a client side error:(site geometry is null)
• Handle navigation links to the project details page (within the app), making sure back functionality works as expected

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp-multi-tenancy-setup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2024 10:44am

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp	⬜️ Ignored (Inspect)			Nov 7, 2024 10:44am
planet-webapp-temp	⬜️ Ignored (Inspect)			Nov 7, 2024 10:44am

[coderabbitai]

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

146 files out of 233 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mariahosfeld]

Looks good to me.