Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing System looking for an error #13

Closed
wants to merge 32 commits into from
Closed

Testing System looking for an error #13

wants to merge 32 commits into from

Conversation

Stepania
Copy link

No description provided.

HamishBrownPFR
HamishBrownPFR reviewed Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@HamishBrownPFR HamishBrownPFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things to check there Sasha

modelCsharp/ConsoleAppSVS-testplot.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this one committed. Shouldn't it be generated by actions

modelCsharp/ConsoleAppSVS-test/out/Apache.Arrow.dll Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of .dll are comitted. Is this necessary? I thought dll's were binaries generated by the build system so did not need to be committed. Quite possible I am wrong here.

@Stepania Stepania closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamishBrownPFR HamishBrownPFR HamishBrownPFR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stepania @HamishBrownPFR