Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror Ratio objective #848

Open
ddudt opened this issue Feb 1, 2024 · 2 comments · May be fixed by #1366
Open

Mirror Ratio objective #848

ddudt opened this issue Feb 1, 2024 · 2 comments · May be fixed by #1366
Assignees
@f0uriest @ddudt
Labels
hackathon Stuff to work on during hackathon objectives Adding or improving objective functions P3 Highest Priority, someone is/should be actively working on this

Comments

@ddudt
Copy link
Collaborator

ddudt commented Feb 1, 2024

Would be useful to have an objective to target a particular mirror ratio. There is already the "mirror ratio" compute quantity, so this is trivial to implement for regular equilibria (can already do it with GenericObjective). The other use case is to implement something similar that can work for OmnigenousField after PR #535 is merged in.
@ddudt ddudt added the objectives Adding or improving objective functions label Feb 1, 2024
@ddudt ddudt self-assigned this Feb 1, 2024
@ddudt ddudt mentioned this issue Feb 1, 2024
Merged
@dpanici
Copy link
Collaborator

dpanici commented Feb 7, 2024

#841 would address this I think

@f0uriest f0uriest added the hackathon Stuff to work on during hackathon label Mar 7, 2024
@f0uriest f0uriest self-assigned this Apr 5, 2024
@dpanici
Copy link
Collaborator

dpanici commented Aug 20, 2024 •
edited
Loading

define in desc/compute/omnigenity.py mirror ratio for parmaterization OmnigenousField, then can use GenericObjective or MirrorRatio as a new obj

@dpanici dpanici added the P3 Highest Priority, someone is/should be actively working on this label Nov 11, 2024
@f0uriest f0uriest linked a pull request Nov 14, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f0uriest f0uriest

@ddudt ddudt

Labels
hackathon Stuff to work on during hackathon objectives Adding or improving objective functions P3 Highest Priority, someone is/should be actively working on this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mirror ratio objective PlasmaControl/DESC
3 participants
@f0uriest @ddudt @dpanici