Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laplace solution #1360

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Laplace solution #1360

wants to merge 16 commits into from

Conversation

unalmis
Copy link
Collaborator

@unalmis unalmis commented Nov 13, 2024

No description provided.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 60.16260% with 49 lines in your changes missing coverage. Please review.

Project coverage is 95.39%. Comparing base (2741269) to head (45405b6).

Files with missing lines Patch % Lines
desc/integrals/singularities.py 58.47% 49 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1360      +/-   ##
==========================================
- Coverage   95.57%   95.39%   -0.18%     
==========================================
  Files          96       96              
  Lines       24405    24522     +117     
==========================================
+ Hits        23325    23393      +68     
- Misses       1080     1129      +49     
Files with missing lines Coverage Δ
desc/compute/_surface.py 100.00% <100.00%> (ø)
desc/magnetic_fields/_core.py 96.61% <100.00%> (ø)
desc/integrals/singularities.py 81.63% <58.47%> (-9.63%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 13, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_midres         |     -0.88 +/- 5.13     | -5.45e-03 +/- 3.16e-02 |  6.11e-01 +/- 2.2e-02  |  6.16e-01 +/- 2.3e-02  |
 test_build_transform_fft_highres        |     -0.32 +/- 3.12     | -3.12e-03 +/- 3.03e-02 |  9.66e-01 +/- 2.2e-02  |  9.69e-01 +/- 2.0e-02  |
 test_equilibrium_init_lowres            |     -0.03 +/- 1.78     | -1.33e-03 +/- 6.87e-02 |  3.86e+00 +/- 4.5e-02  |  3.87e+00 +/- 5.2e-02  |
 test_objective_compile_atf              |     -0.92 +/- 4.77     | -7.27e-02 +/- 3.75e-01 |  7.80e+00 +/- 2.0e-01  |  7.88e+00 +/- 3.2e-01  |
 test_objective_compute_atf              |     +0.07 +/- 3.73     | +6.98e-06 +/- 3.93e-04 |  1.05e-02 +/- 1.3e-04  |  1.05e-02 +/- 3.7e-04  |
 test_objective_jac_atf                  |     +0.94 +/- 3.98     | +1.78e-02 +/- 7.57e-02 |  1.92e+00 +/- 6.3e-02  |  1.90e+00 +/- 4.2e-02  |
 test_perturb_1                          |     -0.57 +/- 2.06     | -7.99e-02 +/- 2.87e-01 |  1.39e+01 +/- 1.3e-01  |  1.39e+01 +/- 2.6e-01  |
 test_proximal_jac_atf                   |     +0.25 +/- 1.07     | +2.04e-02 +/- 8.66e-02 |  8.12e+00 +/- 7.6e-02  |  8.10e+00 +/- 4.2e-02  |
 test_proximal_freeb_compute             |     -1.91 +/- 1.09     | -3.82e-03 +/- 2.19e-03 |  1.96e-01 +/- 1.1e-03  |  2.00e-01 +/- 1.9e-03  |
 test_build_transform_fft_lowres         |     -3.23 +/- 4.39     | -1.83e-02 +/- 2.49e-02 |  5.49e-01 +/- 2.2e-02  |  5.67e-01 +/- 1.2e-02  |
 test_equilibrium_init_medres            |     +2.35 +/- 5.10     | +1.04e-01 +/- 2.25e-01 |  4.52e+00 +/- 1.4e-01  |  4.42e+00 +/- 1.7e-01  |
 test_equilibrium_init_highres           |     -2.36 +/- 3.38     | -1.37e-01 +/- 1.97e-01 |  5.69e+00 +/- 1.4e-01  |  5.83e+00 +/- 1.4e-01  |
 test_objective_compile_dshape_current   |     +3.85 +/- 4.41     | +1.54e-01 +/- 1.76e-01 |  4.15e+00 +/- 7.5e-02  |  4.00e+00 +/- 1.6e-01  |
 test_objective_compute_dshape_current   |     +4.28 +/- 3.15     | +1.54e-04 +/- 1.14e-04 |  3.76e-03 +/- 9.7e-05  |  3.61e-03 +/- 6.0e-05  |
 test_objective_jac_dshape_current       |     +6.04 +/- 9.26     | +2.45e-03 +/- 3.76e-03 |  4.30e-02 +/- 3.1e-03  |  4.06e-02 +/- 2.2e-03  |
 test_perturb_2                          |     -1.27 +/- 2.80     | -2.61e-01 +/- 5.76e-01 |  2.03e+01 +/- 4.0e-01  |  2.06e+01 +/- 4.2e-01  |
 test_proximal_freeb_jac                 |     +1.15 +/- 2.64     | +8.93e-02 +/- 2.06e-01 |  7.87e+00 +/- 1.4e-01  |  7.78e+00 +/- 1.5e-01  |
 test_solve_fixed_iter                   |     -0.37 +/- 60.05    | -1.87e-02 +/- 3.03e+00 |  5.02e+00 +/- 2.1e+00  |  5.04e+00 +/- 2.2e+00  |

@unalmis unalmis changed the title Laplace solution for vacuum plasma Laplace solution Nov 16, 2024
@unalmis unalmis self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants