Feature/exclude external redirect (#18)

* change getSitemapPages to ignore redirect pages that redirect to external URLs * update comment
PlasticStudio · May 12, 2023 · 40792ca · 40792ca
1 parent 7c87dfa
commit 40792ca
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/src/Controller/SitemapXMLController.php b/src/Controller/SitemapXMLController.php
@@ -3,13 +3,14 @@
 namespace PlasticStudio\SEO\Controller;
 
 use Page;
-use PlasticStudio\SEO\Generators\SitemapGenerator;
-use SilverStripe\Control\Controller;
+use SilverStripe\ORM\ArrayList;
 use SilverStripe\Control\Director;
-use SilverStripe\Control\HTTPRequest;
+use SilverStripe\Control\Controller;
 use SilverStripe\Core\Config\Config;
-use SilverStripe\ORM\ArrayList;
+use SilverStripe\Control\HTTPRequest;
 use SilverStripe\ErrorPage\ErrorPage;
+use SilverStripe\CMS\Model\RedirectorPage;
+use PlasticStudio\SEO\Generators\SitemapGenerator;
 
 /**
  * SitemapXML_Controller
@@ -31,7 +32,7 @@ public function init()
     {
         parent::init();
 
-        $this->response->addHeader("Content-Type", "application/xml"); 
+        $this->response->addHeader("Content-Type", "application/xml");
     }
 
     /**
@@ -93,7 +94,13 @@ public function getSitemapPages()
             foreach ($objects as $name => $values) {
                 // exclude error pages, so google doesn't error
                 $list = $name::get()->filter('ClassName:not', ErrorPage::class);
+
                 foreach ($list as $page) {
+                    // Exclude redirector pages that redirect to external URLs, so google doesn't error
+                    if ($page instanceof RedirectorPage && $page->RedirectionType == 'External') {
+                        continue;
+                    }
+
                     if (!$page->SitemapHide) {
                         $pages->push($page);
                     }
@@ -102,4 +109,4 @@ public function getSitemapPages()
         }
         return $pages;
     }
-}
+}