fix: Set default deployment and sandbox values for platforms for first-time user scenarios #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oyment respectively.
paulhazen
added
fix
paulhazen
requested review from
WispyMouse,
arthur740212 and
andrew-hirata-playeveryware
…members, and add ToString method to aid in better logging.
…PlatformConfig for a given PlatformManager.Platform value.
…s been defined in the product config.
…ts the deployment information for all available platforms when a deployment is defined for the first time in ProductConfig.
…an properly be overidden in deriving classes.
… PlatformConfigEditor and it's interface.
…n edits being made to platformconfigs - and properly update the user interface to reflect the changes.
…atform-deployment-from-product
…thin ProductConfig to properly associate the first sandbox and deployments added.
…lid options to select from.
…://github.com/PlayEveryWare/eos_plugin_for_unity into fix/populate-platform-deployment-from-product
…rm-deployment-from-product
…te-platform-deployment-from-product
paulhazen
commented
Jan 17, 2025
| } | ||
| } | ||
|
|
||
| protected override void OnWriteCompleted() |
There was a problem hiding this comment.
Within this PR, this is the meat of the change. All other changes are in service of accomplishing what this function accomplishes. It would be sensible to review the PR starting by reading this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue discovered during the testing of the upcoming release - wherein first-time users would have difficulty properly setting the Deployment information for the platform of their choice.
With this change - when a deployment is set for the first time (by defining a DeploymentId and a SandboxId in EOS Plugin -> EOS Configuration) - that deployment will be selected for each of the platform configurations.
Prior to this change it was possible to get into a state where the deployment set for the platform configuration would be incompletely defined. It was not initially caught because emphasis was placed on testing the most common use scenario - where a user already had deployment values defined. Testing for the release revealed the gap in testing that occluded the first-time user scenario. Such testing is now complete, and this PR addresses the identified shortcomings.
#EOS-2355