feat: User experience for entering invalid product version. #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Version field member within ProductConfig.
…ion is not set properly.
paulhazen
added
bug
paulhazen
requested review from
WispyMouse,
arthur740212 and
andrew-hirata-playeveryware
WispyMouse
reviewed
Feb 7, 2025
com.playeveryware.eos/Runtime/Core/Config/Attributes/Validators/FieldValidator.cs.meta
Show resolved
Hide resolved
WispyMouse
reviewed
Feb 7, 2025
com.playeveryware.eos/Runtime/Core/Config/Attributes/Validators/LengthValidationAttribute.cs
Outdated
Show resolved
Hide resolved
WispyMouse
reviewed
Feb 7, 2025
com.playeveryware.eos/Runtime/Core/Config/Attributes/Validators/LengthValidationAttribute.cs
Show resolved
Hide resolved
WispyMouse
reviewed
Feb 7, 2025
com.playeveryware.eos/Runtime/Core/Config/Attributes/Validators/LengthValidationAttribute.cs
Outdated
Show resolved
Hide resolved
WispyMouse
reviewed
Feb 7, 2025
WispyMouse
approved these changes
Feb 7, 2025
andrew-hirata-playeveryware
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a feature within the Config system that allows attributes to be added to the
productVersionfield member of theProductConfigclass.When the configuration editor window renders the input for this field, if the value is invalid a helpbox will appear above the input, and the input field itself will be highlighted.
Currently, this does not prevent the user from saving an invalid value. Extending implementation to include that is recommended - but is beyond the scope of the task as it is currently described.
Important
It should be noted that implementing the task as described has a side effect that was not considered: When a first-time user loads the editor - they will see a warning indicating that the product version is invalid - but they will not see similar warnings for the other fields that they have yet to fill out.
Some thought needs to be put into whether to simply not display these warnings until a user tries to save - or carve out a special case for first-time users, or (ideally) complete the validation implementation to extend to the other fields that can have attributes similar to the ones contained in this PR applied to them so the behavior is consistent.
#EOS-2236