New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing typing issue with ApiCallback where error or result might be null #125

Open

jondewoo wants to merge 2 commits into PlayFab:master from jondewoo:master

jondewoo commented Nov 29, 2022

From PlayFabSdk/Scripts/PlayFab/PlayFab.js:

if (replyEnvelope.hasOwnProperty("error") || !replyEnvelope.hasOwnProperty("data")) {
    callback(replyEnvelope, null);
} else {
    callback(null, replyEnvelope);
}

jondewoo added 2 commits

November 29, 2022 16:39


          Fixing typing issue with ApiCallback where error or result might be null

efa16da


          Merge branch 'PlayFab:master' into master

e91b529

Author

jondewoo commented Dec 21, 2022

Please consider this PR as the issue is causing errors when strictNullChecks is true in a TypeScript project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet