Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XPlatCppSDK Consumption Docs #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SahilAshar
Copy link
Collaborator

No description provided.

@@ -10,3 +10,29 @@ Please download, unzip, and copy the corresponding asset folder for your platfor
* Android - `/android/bin`
* Win32 - The win32 binaries are not included in the zip assets. They are available on download on [nuget](https://www.nuget.org/packages/Microsoft.PlayFab.PlayFabParty.Cpp.Windows).
* Linux - `/x64/Release/libparty.so`

### Using PlayFab Party in Production
Copy link
Collaborator

@ScottMunroMS ScottMunroMS Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section could be simplified/clarified to just a single warning block

> :warning: - **Pre-built binaries of PlayFabXPlatCppSDK included in release packages are intended only for use in the PartySamples**. These binaries are not intended for production consumption and you should instead build the XPlatCppSDK from source in your project.
>
> On android, this includes the `libparty-android-release/<arch>/lib/libcppsdk.a`
>
> On iOS, this includes `PlayFabParty.framework-for-iOS-Release/PlayFabParty.framework-for-iOS-<arch>-Release/libplayfabxplatcppsdk.a`

Copy link
Collaborator

@ScottMunroMS ScottMunroMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chatting out of band about some additional thoughts/changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants