Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL Database Support #504

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

jon5477
Copy link

@jon5477 jon5477 commented Jan 30, 2024

Fixes #64

  • Adds PostgreSQL support while retaining support for MySQL and SQLite
  • Some refactoring of PreparedStatements to utilize try-with-resources
  • Some refactoring of Statement to PreparedStatements to reduce the likelihood of SQL injection

@0xFEEDC0DE64
Copy link

would love to see this merged, is anything left to do? can I help?

Config option to supply extra parameters to the JDBC string for advanced cases.
Example: Useful for connecting to Postgres behind pgbouncer when set to ?prepareThreshold=0

Signed-off-by: PseudoResonance <[email protected]>
Disables index hinting for Postgres
Adds subquery aliases when creating unions

Signed-off-by: PseudoResonance <[email protected]>
Signed-off-by: PseudoResonance <[email protected]>
@PseudoResonance
Copy link

This is not ready to merge yet, but I've made a few fixes on my own fork. I wasn't able to find any more issues, but if anyone would like to try it out on a test server and see if there are any errors I would appreciate it. Definitely do NOT use this on a production server though.

https://github.com/PseudoResonance/CoreProtect/
CoreProtect-22.2.jar.zip

Fix Postgres lookups/JDBC parameter config option
Copy link

stale bot commented Jun 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 29, 2024
@Intelli Intelli removed the stale label Jun 29, 2024
Copy link

stale bot commented Aug 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 29, 2024
@PseudoResonance
Copy link

Why is there a stale bot for PRs?

@stale stale bot removed the stale label Aug 29, 2024
Copy link

stale bot commented Oct 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 28, 2024
@PseudoResonance
Copy link

Still not stale

@stale stale bot removed the stale label Oct 28, 2024
@0xFEEDC0DE64
Copy link

should I setup a bot that comments every day or week something random?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for PostgreSQL
4 participants