Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FAWE logging on newer builds #528

Merged
merged 9 commits into from
May 12, 2024

Conversation

Telesphoreo
Copy link
Contributor

@Telesphoreo Telesphoreo commented Apr 21, 2024

@Intelli
Copy link
Contributor

Intelli commented Apr 21, 2024

Just to confirm, are the maven/gradle build file changes necessary?

It doesn't appear that you're making any FAWE dependant API calls in your code changes.

@Telesphoreo
Copy link
Contributor Author

No, the build changes don't need to be made. I can revert that. Unfortunately, it appears that running //undo doesn't log the reverted changes in CoreProtect like it does for regular WE. It looks like that's an entirely separate function now. FAWE is genuinely ridiculous.

@VideoGameSmash12
Copy link

FAWE is like a double-edged sword. Sure, it doesn't crash your server when you do a gigantic edit and it has a bunch of neat features, but you will randomly get breaking changes like what happened here.

@Telesphoreo
Copy link
Contributor Author

Telesphoreo commented Apr 24, 2024

Unfortunately, I take it back. CoreProtect doesn't compile with stock WE with these changes. However, I fixed logging with the history commands. I can confirm that everything works with regular WE and FAWE regardless of the build change.

@Telesphoreo
Copy link
Contributor Author

I have removed the enable-awe toggle entirely. AWE is dead and it appears that FAWE registers the same way as WorldEdit. The worldedit toggle being set to true or false will work both for FAWE or regular WE, so I think it should be removed to reduce confusion. Let me know if you want any of that back though

@Intelli Intelli merged commit 42af5dc into PlayPro:master May 12, 2024
3 checks passed
@Telesphoreo Telesphoreo deleted the fix-fawe-logging branch May 12, 2024 18:32
Intelli added a commit that referenced this pull request May 14, 2024
* Fix FAWE logging on newer builds

* fix regular WE logging

* Fix registering of FAWE for event bus

* Remove jcenter

* Add missing `replaceBlocks` method

* Remove FAWE toggle entirely

* oops, i can't do it that way

---------

Co-authored-by: Intelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WorldEdit (FAWE) support doesn't work
3 participants