-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FAWE logging on newer builds #528
Conversation
Just to confirm, are the maven/gradle build file changes necessary? It doesn't appear that you're making any FAWE dependant API calls in your code changes. |
No, the build changes don't need to be made. I can revert that. Unfortunately, it appears that running //undo doesn't log the reverted changes in CoreProtect like it does for regular WE. It looks like that's an entirely separate function now. FAWE is genuinely ridiculous. |
FAWE is like a double-edged sword. Sure, it doesn't crash your server when you do a gigantic edit and it has a bunch of neat features, but you will randomly get breaking changes like what happened here. |
Unfortunately, I take it back. CoreProtect doesn't compile with stock WE with these changes. However, I fixed logging with the history commands. I can confirm that everything works with regular WE and FAWE regardless of the build change. |
I have removed the enable-awe toggle entirely. AWE is dead and it appears that FAWE registers the same way as WorldEdit. The worldedit toggle being set to true or false will work both for FAWE or regular WE, so I think it should be removed to reduce confusion. Let me know if you want any of that back though |
* Fix FAWE logging on newer builds * fix regular WE logging * Fix registering of FAWE for event bus * Remove jcenter * Add missing `replaceBlocks` method * Remove FAWE toggle entirely * oops, i can't do it that way --------- Co-authored-by: Intelli <[email protected]>
Jar download: https://s3.telesphoreo.me/coreprotect/CoreProtect-fork-22.2-v22.2-23-g162c4a8.dirty.jar
Fixes #496