Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese translation patch (Update ja.yml) #672

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

shotadft
Copy link
Contributor

@shotadft shotadft commented Nov 8, 2024

Fixed some translations that were still incomplete as of the last issue (#660).
However, please note that they may be incomplete.

@shotadft
Copy link
Contributor Author

shotadft commented Nov 8, 2024

My guess is that such mistranslations occurred in large numbers because English and Japanese grammar are very different.

@shotadft shotadft closed this Nov 10, 2024
@shotadft shotadft reopened this Nov 10, 2024
@shotadft shotadft changed the title Japanese translation patch Japanese translation patch (Update ja.yml) Nov 10, 2024
@shotadft shotadft marked this pull request as draft November 12, 2024 19:53
Copy link
Contributor Author

@shotadft shotadft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial correction. This should be mostly ok.

@shotadft shotadft marked this pull request as ready for review November 12, 2024 20:16
Copy link

@waxsd100 waxsd100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

気になったところをコメントしました。
全ては見ていません。

I commented on what I was interested in.
I didn't see all of them.

lang/ja.yml Outdated Show resolved Hide resolved
lang/ja.yml Outdated Show resolved Hide resolved
lang/ja.yml Outdated Show resolved Hide resolved
lang/ja.yml Outdated Show resolved Hide resolved
lang/ja.yml Outdated Show resolved Hide resolved
lang/ja.yml Outdated Show resolved Hide resolved
lang/ja.yml Outdated Show resolved Hide resolved
lang/ja.yml Outdated Show resolved Hide resolved
@waxsd100 waxsd100 mentioned this pull request Nov 13, 2024
Copy link
Contributor Author

@shotadft shotadft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waxsd100さん、修正提案ありがとうございます!

Copy link

@waxsd100 waxsd100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ごめん何個か見逃してた。
他にもトランザクションと入れ替えとか色々混ざってる気がするがそこはスルーします。
(気が向いたときにゲーム内確認してこっちで直します)

修正した内容はLGTM

lang/ja.yml Outdated Show resolved Hide resolved
lang/ja.yml Outdated Show resolved Hide resolved
lang/ja.yml Outdated Show resolved Hide resolved
lang/ja.yml Outdated Show resolved Hide resolved
lang/ja.yml Outdated Show resolved Hide resolved
lang/ja.yml Outdated Show resolved Hide resolved
lang/ja.yml Outdated Show resolved Hide resolved
shotadft and others added 5 commits November 15, 2024 02:03
Co-authored-by: waxsd100 <[email protected]>
Co-authored-by: waxsd100 <[email protected]>
Co-authored-by: waxsd100 <[email protected]>
Co-authored-by: waxsd100 <[email protected]>
Co-authored-by: waxsd100 <[email protected]>
@shotadft
Copy link
Contributor Author

ありがとうございます🙇

Copy link

@waxsd100 waxsd100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waxsd100
Copy link

waxsd100 commented Nov 14, 2024

@Intelli please review


This pull request includes various updates and improvements to the Japanese localization file lang/ja.yml. The changes primarily focus on improving the accuracy and clarity of translations, correcting grammatical errors, and enhancing consistency across the file.

Key updates and improvements:

  • Translation Accuracy and Clarity:

    • Updated the translation for "AMOUNT_ENTITY" to "{0}体の{エンティティ|エンティティ}" to improve clarity.
    • Corrected "COMMAND_NOT_FOUND" to "コマンド "{0}" は見つかりません。" for better grammatical accuracy.
    • Modified "ENABLE_SUCCESS" to "{0} が有効化されました。" to ensure proper verb usage.
  • Consistency Enhancements:

    • Standardized the translation for "LOOKUP_BLOCK" to "{0}が{1}を{配置|破壊}した。" to maintain uniformity in action descriptions.
    • Updated "ROLLBACK_STARTED" to "{ロールバック|復元|プレビュー}が「{0}」で開始されました。" for consistent use of quotation marks.
  • Grammatical Corrections:

    • Corrected "DATABASE_LOCKED_1" to "データベースがロックされています。最大15秒間かかる場合があります。" for better readability.
    • Fixed "HELP_LOOKUP_COMMAND" to "ブロックデータを検索します。" to improve sentence structure.
    • Adjusted "INVALID_USERNAME" to ""{0}"は無効なユーザー名です。" to ensure proper punctuation.

Copy link
Contributor Author

@shotadft shotadft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Intelli Please merge and review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants