Refactor code validators #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariodandrea
reviewed
Aug 7, 2024
shaharbar1
force-pushed
the
feature/refactor_code
branch
2 times, most recently
from
5845ac0 to
e6ed987
Compare
adarmiento
reviewed
Aug 7, 2024
shaharbar1
force-pushed
the
feature/refactor_code
branch
from
e6ed987 to
d2b773f
Compare
dariodandrea
reviewed
Aug 8, 2024
dariodandrea
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Good job @shaharbar1! I just left a minor comment for the docstring
Change log: 1. Updated pydantic to 2.8.2 2. Migrated base.py, cmab.py, smab.py, model.py, strategy.py based on new pydantic version. 3. Added utils.py with utility function to convert dict to tict with json seralizable values. 4. Changed relevant "get_state" UTs to use the new utility function.
shaharbar1
force-pushed
the
feature/refactor_code
branch
from
d2b773f to
bcfb91e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log: