Ruff Formatting #34
Merged
Ruff Formatting #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaharbar1
force-pushed
the
feature/ruff_migration
branch
2 times, most recently
from
268f3d0 to
c03066f
Compare
dariodandrea
reviewed
Aug 8, 2024
shaharbar1
force-pushed
the
feature/ruff_migration
branch
from
c03066f to
e7dd1bb
Compare
Change log: 1. Removed black, pylint, flake8, and isort. Replaced all with ruff on .pre-commit-config.yaml. 2. Added compatible ruff definitions on pyproject.toml. Only missing definitions are for pylint variable good names and for ignoring R0903. 3. Formatting now applies to notebooks, so they were changed correspondingly. 4. Reformatted simulation_cmab.py. 5. Changed type tests on UTs to follow "type(...) is ...", rather than type(...) == ..." 6. Removed redundant style checks on continuous_integration.yml
shaharbar1
force-pushed
the
feature/ruff_migration
branch
from
e7dd1bb to
4e232fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log: