Flask login #68
Merged
Flask login #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheoLechemia
commented
Jun 12, 2023
•
TheoLechemia
commented
- Utilisation de flask-login : corrige une faille de sécurité sur les cookie (#2574)
- Ajout de la possibilité de passer le token d'authentification via le header HTTP Authorization Bearer
- La route /login renvoie le token dans le body pour qu'il puisse être récupérer en frontend
- Le support de l'authentification via cookie est maintenu (pour UsersHub)
- Suppression de la fonctionnalité de renouvellement automatique du cookie (qui était non fonctionnelle depuis plusieurs versions)
Codecov ReportAttention:
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
TheoLechemia
force-pushed
the
flask_login
branch
8 times, most recently
from
4ac6c53 to
008ed5b
Compare
bouttier
reviewed
Oct 6, 2023
| @@ -15,6 +17,12 @@ | |||
| } | |||
|
|
|||
|
|
|||
| @pytest.fixture(autouse=True) | |||
src/pypnusershub/decorators.py
Outdated
| def decorated_view(*args, **kwargs): | ||
| if not current_user.is_authenticated: | ||
| raise Unauthorized | ||
| if current_user.max_level_profil < level: |
src/pypnusershub/routes.py
Outdated
| value=token, | ||
| expires=cookie_exp, | ||
| return Response(msg, status=400) | ||
| user = models.User.query.filter(models.User.identifiant == login).one() |
There was a problem hiding this comment.
Cool de plus utiliser AppUser, mais il me semble encore nécessaire de checker l’app et le profile associé non ?
TheoLechemia
force-pushed
the
flask_login
branch
9 times, most recently
from
2ba8bfe to
1040edb
Compare
- remove home made cookie management - support of HTTP Header JWT for authentification
TheoLechemia
force-pushed
the
flask_login
branch
from
1040edb to
3238be3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.