Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/custom authentification #93

Merged
merged 28 commits into from
Jul 16, 2024
Merged

Conversation

jacquesfize
Copy link
Contributor

@jacquesfize jacquesfize commented Mar 29, 2024

In PnX-SI/GeoNature#2976, we propose to enable the customization of the login process to use custom login providers (CAS for instance). This PR includes the required changes of UsersHub-authentification-module to make it work.

@jacquesfize jacquesfize force-pushed the feat/custom_authentification branch 2 times, most recently from 19e64cd to e4c22a8 Compare March 29, 2024 10:54
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 67.85714% with 27 lines in your changes missing coverage. Please review.

Project coverage is 52.84%. Comparing base (975a3eb) to head (e4c22a8).
Report is 10 commits behind head on develop.

Current head e4c22a8 differs from pull request most recent head 4a0144a

Please upload reports for the commit 4a0144a to get more accurate results.

Files Patch % Lines
src/pypnusershub/authentification.py 69.38% 15 Missing ⚠️
src/pypnusershub/routes.py 65.71% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #93      +/-   ##
===========================================
+ Coverage    51.79%   52.84%   +1.05%     
===========================================
  Files           14       15       +1     
  Lines          726      774      +48     
===========================================
+ Hits           376      409      +33     
- Misses         350      365      +15     
Flag Coverage Δ
pytest 52.84% <67.85%> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheoLechemia TheoLechemia force-pushed the feat/custom_authentification branch 2 times, most recently from c305534 to 3d5c714 Compare April 29, 2024 10:21
@TheoLechemia TheoLechemia force-pushed the feat/custom_authentification branch from 9d014b3 to 4b98789 Compare June 3, 2024 15:39
@jacquesfize jacquesfize force-pushed the feat/custom_authentification branch from 4a0144a to 1b9c528 Compare July 3, 2024 07:32
@jacquesfize jacquesfize force-pushed the feat/custom_authentification branch from 47315f7 to 62f24e9 Compare July 5, 2024 09:37
@jacquesfize jacquesfize requested a review from bouttier July 5, 2024 10:08
@TheoLechemia TheoLechemia force-pushed the feat/custom_authentification branch 2 times, most recently from 6d5d633 to 552d5b6 Compare July 16, 2024 11:17
@jacquesfize jacquesfize force-pushed the feat/custom_authentification branch from 62f28ba to 87fadd2 Compare July 16, 2024 13:58
@jacquesfize jacquesfize merged commit f9c220e into develop Jul 16, 2024
4 checks passed
@camillemonchicourt camillemonchicourt deleted the feat/custom_authentification branch November 24, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants