Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev <--- Wallet creation #2

Merged
merged 13 commits into from
Jul 20, 2024
Merged

dev <--- Wallet creation #2

merged 13 commits into from
Jul 20, 2024

Conversation

gregorsternat
Copy link
Collaborator

@gregorsternat gregorsternat commented Jul 15, 2024 •
edited
Loading

Description

Several components have been added, mainly relating to the vertical navbar and wallet creation (selection, etc.).
Added several useful functions such as encryption, decryption and wallet creation with the viem lib.
Added new dependencies such as tailwind viem...

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functional / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

@gregorsternat gregorsternat added the enhancement New feature or request label Jul 15, 2024
Nfire2103
Nfire2103 reviewed Jul 17, 2024
View reviewed changes
package.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est quoi postcss ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Une dépendance nécessaire pour tailwind

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok je savais pas, merci de la précision

src/utils/wallet.ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai pas bien compris les lignes 18 à 21. Normalement dans viem tu peux generate une mnemonic et faire un mnemonic to privatekey

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On peut pas extraire une private key d'une mnemonic avec viem donc faut passer par des lib comme bip39 pour le faire a la main

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai creusé un peu le sujet et effectivement il n'y a pas la possibilité de le faire avec viem ce qui est dommage

package.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que tu utilises les libs @Scure et buffer ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scure oui pour créer ma private key mais buffer non

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok tu pourras supprimer buffer à ton prochain commit stp

@Nfire2103
Copy link
Collaborator

merge sur dev plutôt que sur main

@gregorsternat gregorsternat changed the base branch from main to dev July 18, 2024 09:29
@gregorsternat gregorsternat changed the title main <--- Wallet creation dev <--- Wallet creation Jul 20, 2024
@gregorsternat gregorsternat merged commit 9d497c3 into dev Jul 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nfire2103 Nfire2103 Nfire2103 left review comments

Assignees

@Nfire2103 Nfire2103

@Intermarch3 Intermarch3

@alexandreTimal alexandreTimal

@Sacharbon Sacharbon

@gregorsternat gregorsternat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gregorsternat @Nfire2103 @Intermarch3 @alexandreTimal @Sacharbon