feat: add tracing to corpus API

Pocket · Nov 15, 2024 · eebf621 · eebf621
1 parent 54e4b31
commit eebf621
Show file tree

Hide file tree

Showing 9 changed files with 153 additions and 213 deletions.
diff --git a/infrastructure/curated-corpus-api/src/config/index.ts b/infrastructure/curated-corpus-api/src/config/index.ts
@@ -48,4 +48,9 @@ export const config = {
     timeout: 5,
     startPeriod: 0,
   },
+  tracing: {
+    url: isDev
+      ? 'https://otel-collector.getpocket.dev:443'
+      : 'https://otel-collector.readitlater.com:443',
+  },
 };
diff --git a/infrastructure/curated-corpus-api/src/main.ts b/infrastructure/curated-corpus-api/src/main.ts
@@ -269,10 +269,14 @@ class CuratedCorpusAPI extends TerraformStack {
               name: 'AWS_REGION',
               value: region.name,
             },
+            {
+              name: 'OTLP_COLLECTOR_URL',
+              value: config.tracing.url,
+            },
             {
               name: 'LOG_LEVEL',
-              // do not log http, graphql, or debug events in production
-              value: config.environment === 'Prod' ? 'info' : 'debug',
+              // do not log http, graphql, or debug events
+              value: 'info',
             },
           ],
           logGroup: this.createCustomLogGroup('app'),
@@ -286,6 +290,14 @@ class CuratedCorpusAPI extends TerraformStack {
               name: 'DATABASE_URL',
               valueFrom: `${rds.secretARN}:database_url::`,
             },
+            {
+              name: 'UNLEASH_ENDPOINT',
+              valueFrom: `arn:aws:ssm:${region.name}:${caller.accountId}:parameter/Shared/${config.environment}/UNLEASH_ENDPOINT`,
+            },
+            {
+              name: 'UNLEASH_KEY',
+              valueFrom: `arn:aws:secretsmanager:${region.name}:${caller.accountId}:secret:${config.name}/${config.environment}/UNLEASH_KEY`,
+            },
           ],
         },
       ],
@@ -329,6 +341,8 @@ class CuratedCorpusAPI extends TerraformStack {
             resources: [
               `arn:aws:ssm:${region.name}:${caller.accountId}:parameter/${config.name}/${config.environment}`,
               `arn:aws:ssm:${region.name}:${caller.accountId}:parameter/${config.name}/${config.environment}/*`,
+              `arn:aws:ssm:${region.name}:${caller.accountId}:parameter/Shared/${config.environment}/*`,
+              `arn:aws:ssm:${region.name}:${caller.accountId}:parameter/Shared/${config.environment}`,
             ],
             effect: 'Allow',
           },
@@ -353,11 +367,6 @@ class CuratedCorpusAPI extends TerraformStack {
               'logs:CreateLogStream',
               'logs:DescribeLogStreams',
               'logs:DescribeLogGroups',
-              'xray:PutTraceSegments',
-              'xray:PutTelemetryRecords',
-              'xray:GetSamplingRules',
-              'xray:GetSamplingTargets',
-              'xray:GetSamplingStatisticSummaries',
             ],
             resources: ['*'],
             effect: 'Allow',