Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deleter): add missing parameter store permissions #1038

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

kschelonka
Copy link
Contributor

Adds missing permissions to some shared secrets

@kschelonka kschelonka requested a review from a team as a code owner January 29, 2025 22:22
@kschelonka kschelonka requested review from Gio2018 and removed request for a team January 29, 2025 22:22
Copy link

github-actions bot commented Jan 29, 2025

Plan Result (@infrastructure/account-data-deleter-production)

CI link

Plan: 0 to add, 1 to change, 0 to destroy.
  • Update
    • aws_iam_policy.data-deleter-app_application_ecs_service_ecs-iam_ecs-task-execution-role-policy_B4FDF02D
Change Result (Click me)
  # aws_iam_policy.data-deleter-app_application_ecs_service_ecs-iam_ecs-task-execution-role-policy_B4FDF02D will be updated in-place
  ~ resource "aws_iam_policy" "data-deleter-app_application_ecs_service_ecs-iam_ecs-task-execution-role-policy_B4FDF02D" {
        id               = "arn:aws:iam::996905175585:policy/AccountDataDeleter-Prod-TaskExecutionRolePolicy"
        name             = "AccountDataDeleter-Prod-TaskExecutionRolePolicy"
      ~ policy           = jsonencode(
          ~ {
              ~ Statement = [
                    {
                        Action   = [
                            "secretsmanager:GetSecretValue",
                            "kms:Decrypt",
                        ]
                        Effect   = "Allow"
                        Resource = [
                            "arn:aws:secretsmanager:us-east-1:996905175585:secret:Shared/*",
                            "arn:aws:secretsmanager:us-east-1:996905175585:secret:Shared",
                            "arn:aws:secretsmanager:us-east-1:996905175585:secret:AccountDataDeleter/Prod/*",
                            "arn:aws:secretsmanager:us-east-1:996905175585:secret:AccountDataDeleter/Prod",
                            "arn:aws:secretsmanager:us-east-1:996905175585:secret:AccountDataDeleter-Prod/*",
                            "arn:aws:secretsmanager:us-east-1:996905175585:secret:AccountDataDeleter-Prod",
                            "arn:aws:kms:us-east-1:996905175585:key/fee9bd90-a01f-4212-8b69-9c149a7cdb15",
                        ]
                    },
                  ~ {
                      ~ Resource = [
                          + "arn:aws:ssm:us-east-1:996905175585:parameter/Web/Prod/FIREFOX_WEB_AUTH_CLIENT_SECRET",
                          + "arn:aws:ssm:us-east-1:996905175585:parameter/Web/Prod/FIREFOX_WEB_AUTH_CLIENT_ID",
                          + "arn:aws:ssm:us-east-1:996905175585:parameter/Web/Prod/FIREFOX_AUTH_OAUTH_URL",
                            "arn:aws:ssm:us-east-1:996905175585:parameter/Shared/*",
                            # (2 unchanged elements hidden)
                        ]
                        # (2 unchanged attributes hidden)
                    },
                ]
                # (1 unchanged attribute hidden)
            }
        )
        tags             = {
            "app_code"       = "pocket"
            "component_code" = "pocket-accountdatadeleter"
            "costCenter"     = "Pocket"
            "env_code"       = "prod"
            "environment"    = "Prod"
            "owner"          = "Pocket"
            "service"        = "AccountDataDeleter"
        }
        # (7 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

⚠️ Errors

Copy link

@nzeltzer nzeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kschelonka kschelonka enabled auto-merge (squash) January 29, 2025 22:29
@kschelonka kschelonka disabled auto-merge January 29, 2025 22:29
@kschelonka kschelonka force-pushed the fix/add-missing-param-permissions-ADD branch from ac8f956 to 8e9fef8 Compare January 29, 2025 22:29
@kschelonka kschelonka enabled auto-merge (squash) January 29, 2025 22:30
@kschelonka kschelonka force-pushed the fix/add-missing-param-permissions-ADD branch from 8e9fef8 to d227d2e Compare January 29, 2025 22:30
@kschelonka kschelonka merged commit 3bda8fe into main Jan 29, 2025
18 checks passed
@kschelonka kschelonka deleted the fix/add-missing-param-permissions-ADD branch January 29, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants