Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Host Multi-Game #344

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Vaedz7
Copy link
Contributor

@Vaedz7 Vaedz7 commented Jul 12, 2023

New Program

Features

  • Runs up to 16 Tera Raids on one switch using different games/profiles
  • Opens each game & user instance and runs AutoHost like normal
  • Includes a Post-Raid Delay

Notes

  • Does not include separate Battle AI's for each game. (I recommend just spamming a move as you can rearrange moves in SV to match positions)
  • Does not include separate hosting modes (I'll probably add this in the future)
  • Does not include separate settings (Like Lobby Wait, Description, and Start Players; I'll probably add this as well later on)

Overall
This is a very basic AutoHost program to run multiple raids with the same settings. I'm planning to add more as time goes on. I've tested this only with 2 profiles alternating so it may need some further testing.

@pifopi
Copy link
Member

pifopi commented Jul 12, 2023

you should rebase your PR. The link issues are because my changes are not present on your PR, sorry about that

@Vaedz7
Copy link
Contributor Author

Vaedz7 commented Jul 12, 2023

you should rebase your PR. The link issues are because my changes are not present on your PR, sorry about that

What changes are those? For me it's showing that the branch is fully updated and when I create a new branch from PokemonAutomation/main it is the same as my PR (excluding my changes).

@pifopi
Copy link
Member

pifopi commented Jul 12, 2023

oh it was actually rebased but this change :
Vaedz7@f358d13
removed some of my changes so it broke the linking ^^

@Vaedz7
Copy link
Contributor Author

Vaedz7 commented Jul 12, 2023

oh it was actually rebased but this change : Vaedz7@f358d13 removed some of my changes so it broke the linking ^^

Oh ok! I've fixed that now!

@Mysticial
Copy link
Collaborator

How does this work? If I want to host two dens set to different dates, one of them will be wiped when it tries to go online with the later date? I'm not seeing any date manipulation logic.

@Vaedz7
Copy link
Contributor Author

Vaedz7 commented Jul 14, 2023

How does this work? If I want to host two dens set to different dates, one of them will be wiped when it tries to go online with the later date? I'm not seeing any date manipulation logic.

I now realize that the program should switch dates for dens so I'll add that as an option by tomorrow. I'm not sure if one would be wiped as they are on different games/users so I'll test that out as well.

@Vaedz7
Copy link
Contributor Author

Vaedz7 commented Jul 14, 2023

How does this work? If I want to host two dens set to different dates, one of them will be wiped when it tries to go online with the later date? I'm not seeing any date manipulation logic.

I've now added a skips option to specify how many days ahead of the current date the den is located. The skips won't need to account for moving ahead a date as AutoHost already takes care of that. I haven't yet tested this but will get to it soon!

@Mysticial
Copy link
Collaborator

This approach seems prone to error. What about something that lets you specify the date of every den?

@Vaedz7
Copy link
Contributor Author

Vaedz7 commented Jul 15, 2023

This approach seems prone to error. What about something that lets you specify the date of every den?

That may be a better approach. I'll sort that out by next week and test both approaches to see which runs better.

@Mysticial
Copy link
Collaborator

Looking at the time settings, we only have a setter for the hours. NintendoSwitch_DateReader.cpp
For this program we'll also need setters for the month and year. And you'd need to branch it based on the date format.

In short, not a small change. So I suggest we add the full clock manipulation functions as a separate change/PR first. Then come back to this later.

@Mysticial
Copy link
Collaborator

Mysticial commented Jul 23, 2023

Also worth mentioning that our date format detection only detects if it's a US format or not. While this is enough to distinguish the hour/minutes/seconds/AMPM format for the purpose of setting the hour, it's not enough to distinguish the date format which can be either YYYY/MM/DD or DD/MM/YYYY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants