-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-Host Multi-Game #344
base: main
Are you sure you want to change the base?
Auto-Host Multi-Game #344
Conversation
you should rebase your PR. The link issues are because my changes are not present on your PR, sorry about that |
What changes are those? For me it's showing that the branch is fully updated and when I create a new branch from PokemonAutomation/main it is the same as my PR (excluding my changes). |
oh it was actually rebased but this change : |
Oh ok! I've fixed that now! |
How does this work? If I want to host two dens set to different dates, one of them will be wiped when it tries to go online with the later date? I'm not seeing any date manipulation logic. |
I now realize that the program should switch dates for dens so I'll add that as an option by tomorrow. I'm not sure if one would be wiped as they are on different games/users so I'll test that out as well. |
I've now added a |
This approach seems prone to error. What about something that lets you specify the date of every den? |
That may be a better approach. I'll sort that out by next week and test both approaches to see which runs better. |
Looking at the time settings, we only have a setter for the hours. In short, not a small change. So I suggest we add the full clock manipulation functions as a separate change/PR first. Then come back to this later. |
Also worth mentioning that our date format detection only detects if it's a US format or not. While this is enough to distinguish the hour/minutes/seconds/AMPM format for the purpose of setting the hour, it's not enough to distinguish the date format which can be either YYYY/MM/DD or DD/MM/YYYY. |
New Program
Features
Notes
Overall
This is a very basic AutoHost program to run multiple raids with the same settings. I'm planning to add more as time goes on. I've tested this only with 2 profiles alternating so it may need some further testing.