-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split SSI couple amount for OAP #5276
base: master
Are you sure you want to change the base?
Conversation
ssi = person("ssi", period) | ||
total_countable_income = ssi + income | ||
# The SSI variable assigns SSI to one member of the marital unit if both are eligible | ||
marital_ssi = where(is_joint, person.marital_unit.sum(ssi) / 2, ssi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
marital_ssi = where(is_joint, person.marital_unit.sum(ssi) / 2, ssi) | |
marital_ssi = where(is_joint, person.household.sum(ssi) / 2, ssi) |
I think we want to sum it by household
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SSI is a per member benefit except for the marital unit. So, if the child qualifies for SSI, we would not want that to be counted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a source for this? AFAIUI, spouses could get different portions of the marital unit's total SSI, based on the personal income of each spouse; it's not automatically split 50/50.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that if both spouses are eligible for SSI, they would only receive one check.
FYI, I just realized that I used the wrong variable. Just changed it to use ssi_marital_both_eligible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you share a source on that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What part of that? This seems related but doesn't back this up AFAICT:
Deduct an amount to meet the needs of each dependent child living in the household of
the spouse equal to half the maximum SSI grant benefit standard
Could you please provide a full justification for this change in #5275? We prefer to document rationale in issues especially for nontrivial changes here. I'm not yet convinced so please include legal sources and pointers to our current code that needs correction.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5276 +/- ##
==========================================
- Coverage 99.12% 99.00% -0.12%
==========================================
Files 2592 2612 +20
Lines 37707 38039 +332
Branches 162 166 +4
==========================================
+ Hits 37378 37662 +284
- Misses 297 344 +47
- Partials 32 33 +1 ☔ View full report in Codecov by Sentry. |
@MaxGhenis Can you review this pr? |
fixes #5275