Skip to content

Commit

Permalink
Fix filter on Proxy pallet to allow all extrinsics if ProxyType::Any (#…
Browse files Browse the repository at this point in the history
…945)

There is a filter on ProxyType::Any to remove the ability to do
anything. This changes it to the intended purpose, to allow any.

This was changed to false on 9/12/21 in this commit:

9c18e2b

It should be set to true as the intent of ProxyType::Any is to allow
all.

It can be seen set to any in other chain implementations:

https://github.com/moonbeam-foundation/moonbeam/blob/f99b3ef04c560ab47ad7d569d968808a040a0cd0/runtime/moonbeam/src/lib.rs#L1016


https://github.com/paritytech/substrate/blob/033d4e86cc7eff0066cd376b9375f815761d653c/bin/node/runtime/src/lib.rs#L372

## Checklist before requesting a review
- [x] I have performed a self-review of my code.
- [x] If it is a core feature, I have added thorough tests.
- [x] I removed all Clippy and Formatting Warnings. 
- [x] I added required Copyrights.
  • Loading branch information
Gauthamastro authored Apr 19, 2024
2 parents ca9bda6 + 8efd34b commit 6181bae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion runtimes/mainnet/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ impl Default for ProxyType {
impl InstanceFilter<RuntimeCall> for ProxyType {
fn filter(&self, c: &RuntimeCall) -> bool {
match self {
ProxyType::Any => false,
ProxyType::Any => true,
ProxyType::NonTransfer => !matches!(
c,
RuntimeCall::Balances(..)
Expand Down

0 comments on commit 6181bae

Please sign in to comment.