Develop #885
Merged
Develop #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Describe your changes 1. Solves Polkadex-Substrate/orderbook#872 2. Swap deposit tokens for ED in PDEX automatically 3. Ability to pay withdrawal fees in tokens 4. Claim callable by anyone. ## Issue ticket number and link ## Checklist before requesting a review - [x] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [x] I removed all Clippy and Formatting Warnings. - [x] I added required Copyrights.
## Describe your changes Added test cases to test swap features ## Issue ticket number and link #881
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## mainnet-release #885 +/- ##
===================================================
+ Coverage 36.12% 37.52% +1.39%
===================================================
Files 62 62
Lines 3693 3750 +57
===================================================
+ Hits 1334 1407 +73
+ Misses 2359 2343 -16 ☔ View full report in Codecov by Sentry. |
## Describe your changes The recent substrate upgrade broke our Orderbook offchain RPCs. This PR fixes that. ## Checklist before requesting a review - [x] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [x] I removed all Clippy and Formatting Warnings. - [x] I added required Copyrights.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
v5.4.0 runtime release
spec_version: 312
Checklist before requesting a review