Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl RPCs to access Swap APIs #890

Merged
merged 6 commits into from
Dec 16, 2023
Merged

Impl RPCs to access Swap APIs #890

merged 6 commits into from
Dec 16, 2023

Conversation

zktony
Copy link
Contributor

@zktony zktony commented Dec 13, 2023

Describe your changes

Impl RPCs to access Swap APIs.

@zktony zktony requested a review from Gauthamastro December 13, 2023 06:48
@Gauthamastro
Copy link
Member

LGTM

@Gauthamastro Gauthamastro added the A0-PleaseReview Pull request needs code review. label Dec 13, 2023
Gauthamastro
Gauthamastro previously approved these changes Dec 13, 2023
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Dec 14, 2023
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Dec 14, 2023
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (390523c) 37.49% compared to head (8ab6908) 37.30%.

❗ Current head 8ab6908 differs from pull request most recent head 973d921. Consider uploading reports for the commit 973d921 to get more accurate results

Files Patch % Lines
rpc/swap/src/lib.rs 0.00% 18 Missing ⚠️
nodes/mainnet/src/node_rpc.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #890      +/-   ##
===========================================
- Coverage    37.49%   37.30%   -0.19%     
===========================================
  Files           62       63       +1     
  Lines         3753     3772      +19     
===========================================
  Hits          1407     1407              
- Misses        2346     2365      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zktony
Copy link
Contributor Author

zktony commented Dec 15, 2023

To use RPCs, use follwing commands:-
curl -H "Content-Type: application/json" -d '{"id":1, "jsonrpc":"2.0", "method": "tx_quotePriceExactTokensForTokens", "params": ["PDEX", "<AssetId>", <Amount>, true]}' http://localhost:9944/

@Gauthamastro Gauthamastro merged commit e4cb7d3 into Develop Dec 16, 2023
@Gauthamastro Gauthamastro deleted the zk-api-swap branch December 16, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants