Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thea: Fisherman and Batch Signing #894

Merged
merged 36 commits into from
Feb 1, 2024
Merged

Thea: Fisherman and Batch Signing #894

merged 36 commits into from
Feb 1, 2024

Conversation

Gauthamastro
Copy link
Member

Describe your changes

This PR raises the final changes to core Thea logic by adding Fisherman model for deposits and batch signing for withdrawals

@Gauthamastro Gauthamastro added the A0-PleaseReview Pull request needs code review. label Jan 5, 2024
@Gauthamastro
Copy link
Member Author

@zktony Please add tests for this PR. Let me know if you need any help

@Gauthamastro Gauthamastro removed their assignment Jan 15, 2024
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Jan 15, 2024
@Gauthamastro Gauthamastro removed the request for review from zktony January 15, 2024 06:03
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Jan 15, 2024
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Jan 30, 2024
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Jan 30, 2024
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Jan 30, 2024
serhii-temchenko
serhii-temchenko suggested changes Jan 31, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
pallets/thea-executor/src/mock.rs Outdated Show resolved Hide resolved
pallets/thea-message-handler/src/lib.rs Outdated Show resolved Hide resolved
@Gauthamastro
Copy link
Member Author

Gauthamastro commented Jan 31, 2024 •
edited by zktony
Loading

@zktony , The pending tests.

  • on_init in thea
  • paramaterization of on_initialize function in thea
  • validate_signed_outgoing_message
  • submit_incoming_message
  • match statement inside incoming_message extrinsic in thea message handler.
  • validate_incoming_message in thea message handler ( else blocks are not tested )
  • on_initialize in thea executor
  • paramaterization of on_initialize function in thea executor
  • add_signature() else condition, contains_signature() methods of SignedMessage in types
  • amount_in_foreign_decimals() method of Deposit type in types.rs

@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Feb 1, 2024
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Feb 1, 2024
@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Feb 1, 2024
@zktony zktony self-requested a review February 1, 2024 07:09
@Gauthamastro Gauthamastro merged commit fc9432d into Develop Feb 1, 2024
2 checks passed
@Gauthamastro Gauthamastro deleted the gj/thea-final branch February 1, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhii-temchenko serhii-temchenko serhii-temchenko approved these changes

@zktony zktony zktony approved these changes

Assignees

@zktony zktony

Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gauthamastro @zktony @serhii-temchenko