clippy

PolyhedraZK · Sep 4, 2024 · 762a757 · 762a757
1 parent e6397f0
commit 762a757
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 18 deletions.
diff --git a/src/prover/gkr.rs b/src/prover/gkr.rs
@@ -1,13 +1,11 @@
 //! This module implements the core GKR IOP.
 
-use std::ops::Mul;
 
 use arith::{Field, SimdField};
 use ark_std::{end_timer, start_timer};
 
 use crate::{
-    eq_eval_at, sumcheck_prove_gkr_layer, Circuit, GKRConfig, GkrScratchpad, MultiLinearPoly,
-    SumcheckGkrHelper, Transcript,
+    sumcheck_prove_gkr_layer, Circuit, GKRConfig, GkrScratchpad, MultiLinearPoly, Transcript,
 };
 
 // FIXME

diff --git a/src/prover/sumcheck.rs b/src/prover/sumcheck.rs
@@ -119,10 +119,7 @@ pub fn sumcheck_prove_gkr_square_layer<C: GKRConfig>(
 
 #[cfg(test)]
 mod tests {
-    use crate::{
-        sumcheck_prove_gkr_layer, utils::KECCAK_M31_CIRCUIT, BN254ConfigKeccak, Circuit, GKRConfig,
-        GkrScratchpad, Keccak256hasher, RawCommitment, Transcript,
-    };
+    use crate::BN254ConfigKeccak;
 
     type C = BN254ConfigKeccak;
 

diff --git a/src/prover/sumcheck_helper.rs b/src/prover/sumcheck_helper.rs
@@ -448,15 +448,15 @@ impl<'a, C: GKRConfig> SumcheckGkrHelper<'a, C> {
 
     pub(crate) fn prepare_simd(&mut self) {
         eq_eval_at(
-            &self.r_simd0,
+            self.r_simd0,
             &C::ChallengeField::one(),
             &mut self.sp.eq_evals_at_r_simd0,
             &mut self.sp.eq_evals_first_half,
             &mut self.sp.eq_evals_second_half,
         );
 
         eq_eval_at(
-            &self.r_simd1,
+            self.r_simd1,
             &C::ChallengeField::one(),
             &mut self.sp.eq_evals_at_r_simd1,
             &mut self.sp.eq_evals_first_half,
@@ -570,7 +570,7 @@ impl<'a, C: GKRConfig> SumcheckGkrHelper<'a, C> {
             &C::ChallengeField::one(),
             &mut self.sp.eq_evals_at_r_simd0,
             &mut self.sp.eq_evals_first_half,
-            &mut &mut self.sp.eq_evals_second_half,
+            &mut self.sp.eq_evals_second_half,
         );
         let eq_evals_at_r_simdx = C::Field::pack(&self.sp.eq_evals_at_r_simd0);
 

diff --git a/src/verifier.rs b/src/verifier.rs
@@ -1,6 +1,6 @@
 use std::{io::Cursor, vec};
 
-use arith::{ExtensionField, Field, SimdField};
+use arith::{ExtensionField, Field};
 use ark_std::{end_timer, iterable::Iterable, start_timer};
 
 #[cfg(feature = "grinding")]
@@ -165,10 +165,10 @@ fn sumcheck_verify_gkr_layer<C: GKRConfig>(
             r_simd1,
             alpha,
             beta,
-            &vec![],
-            &vec![],
-            &vec![],
-            &vec![],
+            &[],
+            &[],
+            &[],
+            &[],
         );
 
     let mut rx = vec![];
@@ -196,9 +196,9 @@ fn sumcheck_verify_gkr_layer<C: GKRConfig>(
             alpha,
             beta,
             &rx,
-            &vec![],
+            &[],
             &r_simdx,
-            &vec![],
+            &[],
         );
     transcript.append_challenge_f::<C>(&vx_claim);
 
@@ -215,7 +215,7 @@ fn sumcheck_verify_gkr_layer<C: GKRConfig>(
         == vx_claim
             * vy_claim
             * eval_sparse_circuit_connect_poly(
-                &layer.mul, rz0, rz1, r_simd0, r_simd1, alpha, beta, &rx, &ry, &r_simd0, &r_simd1,
+                &layer.mul, rz0, rz1, r_simd0, r_simd1, alpha, beta, &rx, &ry, r_simd0, r_simd1,
             );
     transcript.append_challenge_f::<C>(&vy_claim);
     (verified, rx, ry, r_simdx, r_simdy, vx_claim, vy_claim)