-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage request as an upload #243
base: master
Are you sure you want to change the base?
Conversation
Any update on this? |
Ping? |
@Westbrook FWIW, I implemented this on my own and for some reason the progress property is not propagating up to the iron-ajax element. very weird. |
@btelles Implemented from my fork? Did you instal via bower.json? I had a pita of a time getting bower to recognize that as the version to use vs the ones pointed to in other dependencies. If you are working from my code I'd be glad to hear your experience and see if we can't find the right changes to support a wide set of users for this. I actually just released my feature based on these changes this morning, but I could have easily been working around something on accident in my own code. |
This is also in reference to #235.
This is a first pass at this PR as I have a number of questions about what form a more complete implementation should be.
Here I've added an
isUpload
property to both theiron-ajax
andiron-upload
so that when it is set totrue
the listener iniron-request
that updates theprogress
property is attached toxhr.upload
instead of justxhr
. This allows the implementer to track file uploads into the UI, etc.First, I'm wondering if when uploading all events tracked in
send()
should be pointed toxhr.upload
. Second, should this actually be an even greater change where theprogress
object be duplicated intouploadProgress
anddownloadProgress
so that both objects and listeners can be tracked at all times?Once that is figured out, I'd look for insight on good ways to add tests for this. There doesn't seem to be any test in
iron-request
for progress, and this seems like it might be a good place to do so?