Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Encode falsey values #78

Closed
wants to merge 1 commit into from
Closed

Encode falsey values #78

wants to merge 1 commit into from

Conversation

hyyan
Copy link

@hyyan hyyan commented Apr 20, 2017

Fixes #77.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@hyyan
Copy link
Author

hyyan commented Apr 20, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@hyyan
Copy link
Author

hyyan commented Apr 24, 2017

Hey, is there a chance to merge this PR ?

@e111077 e111077 changed the title Fix issue #77 Encode falsey values Jan 10, 2018
@e111077
Copy link
Contributor

e111077 commented Jan 10, 2018

Passed initial review. Can you please fix the conflicts and add this case to our tests?

@hyyan hyyan closed this Jan 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants