-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow styling of placeholder on paper-input #676 #677
Conversation
This change would allow developers to deliberately change only the color of the input's placeholder using `--paper-input-container-input-placeholder-color` without breaking previous styles by setting the default value to the previous setup.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I can't figure out why the travis-ci build failed from it's log, and I just filled out the CLA form. |
CLAs look good, thanks! |
currently working on a large refactor of paper-input. This PR may be delayed because of this |
@@ -134,15 +134,15 @@ Polymer({ | |||
} | |||
|
|||
input::-webkit-input-placeholder { | |||
color: var(--paper-input-container-color, var(--secondary-text-color)); | |||
color: var(--paper-input-container-input-placeholder-color, var(--paper-input-container-color, var(--secondary-text-color))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add to documentation at the top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@e111077 @ChrisBrownie55 Can this be made in a CSS mixin? I really need to be able to modify more than color ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acory The @apply
rule has been abandoned according to https://chromium.googlesource.com/chromium/src/+/5874fca7324e4523a4bdecc8999bdadfdb6c4eff
Therefore, it could be possible to add that in but it would also make sense to leave this in as well. That way both would still be supported.
However, I would suggest not using the @apply
rule at all seeing as it is only supported for backward compatibility purposes and the Shadow Parts specification is currently the future.
Any news on whether or not this is going to be merged anytime soon? @e111077 |
Still not yet, unfortunately. It might be best to fork this repo for now |
Fixes #676
This fixes #676 by allowing developers to deliberately change just the color of the input's placeholder using
--paper-input-container-input-placeholder-color
.