Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable knob size #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LostInBrittany
Copy link

Fix #154 - Make knob size configurable

Fix #154 - Make knob size configurable

Description

I use paper-slider in metro-like tiles, and in order to make them look good, I give them a high --paper-slider-height.

Currently the knob size is fixed to 10px+ --paper-slider-height (and it's inside a knob container div of 30px + --paper-slider-height ). With big values of --paper-slider-height (let's say 10px), the knob looks too small.

I thought that a --paper-slider-knob-size would be a worthy and fitting addition to the CSS custom properties available for paper-slider.

Actual look

High --paper-slider-height without --paper-slider-knob-size:

paper-slider-before

Desired look

High --paper-slider-height with --paper-slider-knob-size, using the modified version on my fork:

paper-slider-after

Live Demo

Example: http://jsbin.com/pilogib/4/edit?html,output

Tested on

  • [x ] Chrome
  • Firefox
  • Safari 9
  • Safari 8
  • Safari 7
  • Edge
  • IE 11
  • IE 10

@basnijholt
Copy link

Why isn't this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make knob size configurable
3 participants