Migrated from navigating with parameters to type-safe navigation #162
Conversation
|
Wow! Thanks a lot! It was on my to-do list, but I hadn't found the time (and was also feeling lazy) to do it, haha. I'll try to review it soon. |
There was a problem hiding this comment.
Hi, the changes look good and seem to work well. However, as I can see, you've only migrated screens that took arguments via the navigation backstack, but not all the other regular screens, which are still using string-based routes. I would like to migrate them as well and eliminate string-based routes completely. This will make the code much more consistent with the new type-safe navigation design and also make it more understandable for other contributors, like you, since we won't be mixing two different types of navigation APIs when one could handle everything in a better way.
Love to hear your feedback regarding this i'll change the whole screens to the new navigation api. |
Handled multiple times screen navigation on tap of Home from drawer
|
@starry-shivam Hey man just updated below points in this PR |
app/src/main/java/com/starry/greenstash/ui/navigation/NavGraph.kt
Outdated
Show resolved
Hide resolved
… checking at compile time. Removed Gradle migration to type-safe navigation comment line. Added back Header Comment in NormalScreens file.
Description
Migrated from navigating with parameters to type-safe navigation
Type of change
Pull Request checklist